CVE-2024-4435: ic-stable-structures vulnerable to BTreeMap memory leak when deallocating nodes with overflows
When storing unbounded types in a BTreeMap
, a node is represented as a linked list of “memory chunks”. It was discovered recently that when we deallocate a node, in some cases only the first memory chunk is deallocated, and the rest of the memory chunks remain (incorrectly) allocated, causing a memory leak.
In the worst case, depending on how a canister uses the BTreeMap
, an adversary could interact with the canister through its API and trigger interactions with the map that keep consuming memory due to the memory leak. This could potentially lead to using an excessive amount of memory, or even running out of memory.
This issue has been fixed in #212 by changing the logic for deallocating nodes to ensure that all of a node’s memory chunks are deallocated. Tests have been added to prevent regressions of this nature moving forward.
Note: Users of stable-structure < 0.6.0 are not affected.
References
- docs.rs/ic-stable-structures/0.6.4/ic_stable_structures
- github.com/advisories/GHSA-3rcq-39xp-7xjp
- github.com/dfinity/stable-structures
- github.com/dfinity/stable-structures/commit/4f6b8ae521884833498bae26369c353c10f28ea7
- github.com/dfinity/stable-structures/pull/212
- github.com/dfinity/stable-structures/security/advisories/GHSA-3rcq-39xp-7xjp
- internetcomputer.org/docs/current/developer-docs/smart-contracts/maintain/storage
- nvd.nist.gov/vuln/detail/CVE-2024-4435
Detect and mitigate CVE-2024-4435 with GitLab Dependency Scanning
Secure your software supply chain by verifying that all open source dependencies used in your projects contain no disclosed vulnerabilities. Learn more about Dependency Scanning →