CVE-2021-21411: OAuth2-Proxy's `--gitlab-group` GitLab Group Authorization config flag stopped working in v7.0.0
The --gitlab-group flag for group-based authorization in the GitLab provider stopped working in the v7.0.0 release.
Regardless of the flag settings, authorization wasn’t restricted. Additionally, any authenticated users had whichever groups were set in --gitlab-group added to the new X-Forwarded-Groups header to the upstream application.
While adding GitLab project based authorization support in #630, a bug was introduced where the user session’s groups field was populated with the --gitlab-group config entries instead of pulling the individual user’s group membership from the GitLab Userinfo endpoint. When the session groups where compared against the allowed groups for authorization, they matched improperly (since both lists were populated with the same data) so authorization was allowed.
References
- docs.gitlab.com/ee/user/group
- github.com/advisories/GHSA-652x-m2gr-hppm
- github.com/oauth2-proxy/oauth2-proxy
- github.com/oauth2-proxy/oauth2-proxy/commit/0279fa7dff1752f1710707dbd1ffac839de8bbfc
- github.com/oauth2-proxy/oauth2-proxy/releases/tag/v7.1.0
- github.com/oauth2-proxy/oauth2-proxy/security/advisories/GHSA-652x-m2gr-hppm
- nvd.nist.gov/vuln/detail/CVE-2021-21411
- pkg.go.dev/github.com/oauth2-proxy/oauth2-proxy/v7
Code Behaviors & Features
Detect and mitigate CVE-2021-21411 with GitLab Dependency Scanning
Secure your software supply chain by verifying that all open source dependencies used in your projects contain no disclosed vulnerabilities. Learn more about Dependency Scanning →