GMS-2019-58: Failure to sanitize quotes which can lead to sql injection in squel
(updated )
All versions of squel
are vulnerable to sql injection.
The squel
package does not properly escape user provided input when provided using the setFields
method. This could lead to sql injection if the query was then executed.
Proof of concept demonstrating the injection of a single quote into a generated sql statement from user provided input.
> console.log(squel.insert().into('buh').setFields({foo: "bar'baz"}).toString());
INSERT INTO buh (foo) VALUES ('bar'baz')
``` ## Recommendation
There is no fix at this time and the issue has been reported publicly. Consider using another query builder that provides strong guarantees for input sanitization to prevent sql injection attacks.
References
Detect and mitigate GMS-2019-58 with GitLab Dependency Scanning
Secure your software supply chain by verifying that all open source dependencies used in your projects contain no disclosed vulnerabilities. Learn more about Dependency Scanning →